1 SC2328

Vidar Holen edited this page 2024-04-14 19:04:26 -07:00

Table of Contents

• This redirection takes output away from the command substitution.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:
• Related resources:

This redirection takes output away from the command substitution.

(and companion warning "This command substitution will be empty because the command's output gets redirected away" which points to the relevant command substitution)

Problematic code:

var=$(tr -d ':' < input.txt > output.txt)

Correct code:

# If the output should be captured INSTEAD OF being written to file
var=$(tr -d ':' < input.txt)

# If the output should be captured IN ADDITION to being written to file
var=$(tr -d ':' < input.txt | tee output.txt)

# If the output should NOT BE captured at all
tr -d ':' < input.txt > output.txt

Rationale:

ShellCheck has found a command substitution ($(..), `..`) that appears to never capture any output because the command's output is being redirected.

Decide whether you want the output to be captured (by removing the redirection), to go into wherever it's redirected (by not running the command in a command substitution), or both (by using tee to copy the output to both file and stdout).

Exceptions:

None

Related resources:

• Help by adding links to BashFAQ, StackOverflow, man pages, POSIX, etc!

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.