1 SC2258

Rushen Wang edited this page 2024-09-09 20:46:46 +08:00

Table of Contents

• The trailing comma is part of the value, not a separator. Delete or quote it.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:
• Related resources:

The trailing comma is part of the value, not a separator. Delete or quote it.

Problematic code:

for f in foo, bar, baz
do
  echo "$f"
done

Correct code:

for f in foo bar baz
do
  echo "$f"
done

or

for f in "foo," "bar," "baz,"
do
  echo "$f"
done

Rationale:

ShellCheck found a for loop where the items appear to be separated by commas. These will be treated as literal commas. If the commas are part of the value, enclose them in quotes, or remove them.

Exceptions:

None

Related resources:

• Help by adding links to BashFAQ, StackOverflow, man pages, POSIX, etc!

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.