1 SC2265

Vidar Holen edited this page 2022-11-02 20:15:19 -07:00

Table of Contents

• Use && for logical AND. Single & will background and return true.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:
• Related resources:

Use && for logical AND. Single & will background and return true.

Problematic code:

if [ "$1" = "install" ] & [ "$USER" != "root" ]
then
  echo "Must be root to install"
fi

Correct code:

if [ "$1" = "install" ] && [ "$USER" != "root" ]
then
  echo "Must be root to install"
fi

Rationale:

ShellCheck found a test command followed by a &. This runs the test in the background, effectively ignoring it. To specify "logical AND" between two commands, use &&.

Exceptions:

None

Related resources:

• Help by adding links to BashFAQ, StackOverflow, man pages, POSIX, etc!

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.