1 SC2218

koalaman edited this page 2017-07-10 23:19:18 -07:00

Table of Contents

• This function is only defined later. Move the definition up.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:

This function is only defined later. Move the definition up.

Problematic code:

#!/bin/sh
myfunction

myfunction() {
  echo "Hello World"
}

Correct code:

#!/bin/sh
myfunction() {
  echo "Hello World"
}
myfunction

Rationale:

You are calling a function that you are defining later in the file. The function definition must come first.

Function definitions are much like variable assignments, and define a name at the point the definition is "executed". This is why they must happen before their first use.

This is especially apparent when defining functions conditionally:

case "$(uname -s)" in
  Linux) hi() { echo "Hello from Linux"; } ;;
  Darwin) hi() { echo "Hello from macOS"; } ;;
  *) hi() { echo "Hello from something else"; } ;;
esac

hi

Exceptions:

None.

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.