3 SC2027

Vidar Holen edited this page 2015-10-03 21:33:27 -07:00

Table of Contents

• The surrounding quotes actually unquote this. Remove or escape them.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions

The surrounding quotes actually unquote this. Remove or escape them.

Problematic code:

echo "You enter "$HOSTNAME". You can smell the wumpus." >> /etc/issue

Correct code:

echo "You enter $HOSTNAME. You can smell the wumpus." >> /etc/issue

Rationale:

Always quoting variables and command expansions is good practice, but blindly putting quotes left and right of them is not.

In this case, ShellCheck has noticed that the quotes around the expansion are unquoting it, because the left quote is terminating an existing double quoted string, while the right quote starts a new one:

echo "You enter "$HOSTNAME". You can smell the wumpus."
     |----------|         |---------------------------|
        Quoted   No quotes           Quoted

If the quotes were supposed to be literal, they should be escaped. If the quotes were supposed to quote an expansion (as in the example), they should be removed because this is already a double quoted string.

Exceptions

None.

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.