1 SC2323

Vidar Holen edited this page 2022-07-24 14:54:35 -07:00

Table of Contents

• a[(x)] is the same as a[x]. Prefer not wrapping in additional parentheses.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:
• Related resources:

a[(x)] is the same as a[x]. Prefer not wrapping in additional parentheses.

Similarly $(( (x) )) is the same as $(( x )), (( (x) )) is the same as (( x )).

Problematic code:

array[(x+1)]=val
echo $(( (x+1) ))

Correct code:

array[x+1]=val
echo $((x+1))

Rationale:

ShellCheck found an entire arithmetic expression wrapped in parentheses. This does not serve a purpose since the expression is already clearly delimited by the construct it's in, such as array[..]= or $((..)) in the example.

Note: ShellCheck does not warn about redundant parentheses in subexpressions, such as (a*b)+c. Feel free to use parentheses to clarify the order of operations any way you'd like. ShellCheck only emits this suggestion when the entire expression is wrapped twice.

Exceptions:

If you prefer having an extra layer of parentheses for stylistic reasons, you can ignore this message.

Related resources:

• Help by adding links to BashFAQ, StackOverflow, man pages, POSIX, etc!

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.