2 SC2193

koalaman edited this page 2018-01-19 11:50:15 -08:00

Table of Contents

• The arguments to this comparison can never be equal. Make sure your syntax is correct.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:

The arguments to this comparison can never be equal. Make sure your syntax is correct.

Problematic code:

[ $var+1 == 5 ]              # Unevaluated math
[ "{$var}" == "value" ]      # Swapped around $ and {
[ "$(cmd1) | cmd2" == "42" ] # Ended with ) too soon
[[ "$var " == *.png ]]       # Trailing space

Correct code:

[ $((var+1)) == 5 ]          # Evaluated math
[ "${var}" == "value" ]      # Correct variable expansion
[ "$(cmd1 | cmd2)" == "42" ] # Correct command substitution
[[ "$var" == *.png ]]        # No trailing space

Rationale:

ShellCheck has determined that the two values you're comparing can never be equal.

Most of the time, this happens because of a syntax issue that introduced unintended literal characters into one of the arguments.

The left-hand side in the problematic examples will always contain (respectively) curly braces, pipe and trailing space. The right-hand sides are literal values and a pattern without trailing spaces, so they will never be equal. The statement is therefore useless, strongly indicating a bug.

Exceptions:

None.

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.