3 SC2234

Vidar Holen edited this page 2021-08-30 11:07:04 -07:00

Table of Contents

• Remove superfluous (..) around test command to avoid subshell overhead.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:
• Related resources:

Remove superfluous (..) around test command to avoid subshell overhead.

Problematic code:

([ "$x" -gt 0 ]) && foo

Correct code:

[ "$x" -gt 0 ] && foo

Rationale:

You are wrapping a single test command in (..), creating an unnecessary subshell. This serves no purpose, but is significantly slower:

$ i=0; time while ( [ "$i" -lt 10000 ] ); do i=$((i+1)); done
real    0m6.998s
user    0m3.453s
sys     0m3.464s

$ i=0; time while [ "$i" -lt 10000 ]; do i=$((i+1)); done
real    0m0.055s
user    0m0.054s
sys     0m0.001s

Just delete the surrounding (..) since they serve no purpose and only slows the script down.

Exceptions:

This issue only affects performance, not correctness, and can be ignored for stylistic reasons.

Related resources:

• Help by adding links to BashFAQ, StackOverflow, man pages, POSIX, etc!

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.