5 SC2149

Joachim Ansorg edited this page 2021-11-12 19:39:50 +01:00

Table of Contents

• Remove $/${} for numeric index, or escape it for string.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions

Remove $/${} for numeric index, or escape it for string.

Problematic code:

# Regular array
index=42
echo $((array[$index]))

or

# Associative array
index=banana
echo $((array[$index]))

Correct code:

# Regular array
index=42
echo $((array[index]))

or

# Associative array
index=banana
echo $((array[\$index]))

Rationale:

For a numerically indexed array, the $ is mostly pointless and can be removed like in SC2004.

For associative arrays, the $ should be escaped to avoid accidental dereferencing:

declare -A array
index='$1'
array[$index]=42
echo "$(( array[$index] ))"    # bash: array: bad array subscript
echo "$(( array[\$index] ))"   # 42

Exceptions

None.

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.