5 SC2149
Joachim Ansorg edited this page 2021-11-12 19:39:50 +01:00

Remove $/${} for numeric index, or escape it for string.

Problematic code:

# Regular array
index=42
echo $((array[$index]))

or

# Associative array
index=banana
echo $((array[$index]))

Correct code:

# Regular array
index=42
echo $((array[index]))

or

# Associative array
index=banana
echo $((array[\$index]))

Rationale:

For a numerically indexed array, the $ is mostly pointless and can be removed like in SC2004.

For associative arrays, the $ should be escaped to avoid accidental dereferencing:

declare -A array
index='$1'
array[$index]=42
echo "$(( array[$index] ))"    # bash: array: bad array subscript
echo "$(( array[\$index] ))"   # 42

Exceptions

None.