11

SC2251

Benjamin Drung edited this page 2025-01-13 14:18:47 +01:00

Table of Contents

• This ! is not on a condition and skips errexit. Add || exit 1 or make sure $? is checked.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:
• Related resources:

This ! is not on a condition and skips errexit. Add || exit 1 or make sure $? is checked.

Problematic code:

set -e
! false
rest

Correct code:

set -e
! false || exit 1

Rationale:

ShellCheck has found a command inverted with ! that may have no effect. In particular, it does not appear as a condition in an if statement or while loop, or as the final command in a script or function.

The most common reason for this is thinking that it'll trigger set -e aka errexit if a command succeeds, as in the example. This is not the case: ! will inhibit errexit both on success and failure of the inverted command.

Adding || exit will instead exit with failure when the command succeeds.

Exceptions:

ShellCheck will not detect cases where $? is implicitly or explicitly used to check the value afterwards:

set -e;
check_success() { [ $? -eq 0 ] || exit 1; }
! false; check_success
! true; check_success

In this case, you can ignore the warning.

Related resources:

• StackOverflow: Why do I need parenthesis In bash set -e and negated return code
• The "Use && exit 1" for SC2251 can result in a wrong exit code

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.