2 SC2056

Joachim Ansorg edited this page 2021-11-12 19:26:08 +01:00

Table of Contents

• You probably wanted && here
• Problematic code:
• Correct code:
• Rationale:
• Exceptions

You probably wanted && here

Problematic code:

if  (( $1 != 0 || $1 != 3 ))
then
  echo "$1 is not 0 or 3"
fi

Correct code:

if  (( $1 != 0 && $1 != 3 ))
then
  echo "$1 is not 0 or 3"
fi

Rationale:

This is not a bash issue, but a simple, common logical mistake applicable to all languages.

(( $1 != 0 || $1 != 3 )) is always true:

• If $1 = 0 then $1 != 3 is true, so the statement is true.
• If $1 = 3 then $1 != 0 is true, so the statement is true.
• If $1 = 42 then $1 != 0 is true, so the statement is true.

(( $1 != 0 && $1 != 3 )) is true only when $1 is not 0 and not 3:

• If $1 = 0, then $1 != 3 is false, so the statement is false.
• If $1 = 3, then $1 != 0 is false, so the statement is false.
• If $1 = 42, then both $1 != 0 and $1 != 3 is true, so the statement is true.

This statement is identical to ! (( $1 == 0 || $1 == 3 )), which also works correctly.

Exceptions

None.

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.