2 SC1139

Joachim Ansorg edited this page 2021-11-12 19:12:21 +01:00

Table of Contents

• Use || instead of -o between test commands.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:
• Related resources:

Use || instead of -o between test commands.

And variations, like "Use && instead of and".

Problematic code:

if [ "$1" = "-v" ] -o [ -n "$VERBOSE" ]
then
  echo "Verbose log"
fi

Correct code:

if [ "$1" = "-v" ] || [ -n "$VERBOSE" ]
then
  echo "Verbose log"
fi

Rationale:

You have a [ .. ] or [[ .. ]] test expression followed by -o/-a (or by Python-style or/and).

-o and -a work inside [ .. ], but they do not work between them. The Python operators or and and are never recognized in Bash.

To join two separate test expressions, instead use || for "logical OR", or && for "logical AND".

Exceptions:

None

Related resources:

• Help by adding links to BashFAQ, StackOverflow, man pages, POSIX, etc!

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.