2 SC2165

Vidar Holen edited this page 2015-10-03 21:33:27 -07:00

Table of Contents

• This nested loop overrides the index variable of its parent.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:

This nested loop overrides the index variable of its parent.

And companion warning "This parent loop has its index variable overridden."

Problematic code:

for((i=0; i<10; i++))
do
  for i in *
  do
    echo "$i"
  done
done

Correct code:

for((i=0; i<10; i++))
do
  for j in *
  do
    echo "$j"
  done
done

Rationale:

When nesting loops, especially arithmetic for loops, using the same loop variable can cause unexpected results.

In the problematic code, i will contain the last filename from the inner loop, which will be interpreted as a value in the next iteration out the outer loop. This results in either an infinite loop or a syntax error, depending on whether the last filename is a valid shell variable name.

In nested for-in loops, variable merely shadow each other and won't cause infinite loops or syntax errors, but reusing the variable name is rarely intentional.

Exceptions:

None.

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.