2 SC2054

koalaman edited this page 2016-09-29 14:15:55 -07:00

Table of Contents

• Use spaces, not commas, to separate array elements.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:

Use spaces, not commas, to separate array elements.

Problematic code:

flags=("-l", "-d", "--sort=size")
ls "${flags[@]}"

Correct code:

flags=("-l" "-d" "--sort=size")
ls "${flags[@]}"

Rationale:

You appear to have used commas to separate array elements in an array assignment. Other languages require this, but bash instead treats the commas as literal strings.

In the problematic code, the first element is -l, with the trailing comma, and the executed command ends up being ls -l, -d, --sort=size.

In the correct code, the trailing commas have been removed, and the command will be ls -l -d --sort=size as expected.

Exceptions:

None (if you actually want a trailing comma in your strings, move them inside the quotes).

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.