3 SC2315

Joachim Ansorg edited this page 2021-11-15 11:30:17 +01:00

Table of Contents

• In bats, ! does not cause a test failure. Fold the ! into the conditional!
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:
• Related resources:

In bats, ! does not cause a test failure. Fold the ! into the conditional!

Problematic code:

#!/usr/bin/env bats

@test "test" {
    # ... code
    ! [ $status == 0 ]
    # ... more code
}

Correct code:

#!/usr/bin/env bats

@test "test" {
    # ... code
    [ $status != 0 ]
    # ... more code
}

Rationale:

Bats uses set -e and trap ERR to catch test failures as early as possible. Although the return code of a ! negated command is inverted, they will never trigger errexit, due to a bash design decision (see Related Resources). This means that tests which use ! can never fail.

Exceptions:

The return code of the last command in the test will be the exit code of the test function. This means that you can use ! <command> on the last line of the test and it will still fail appropriately. However, you are encouraged to still transform the code in this case for consistency.

Related resources:

• SC2314: In bats, ! does not cause a test failure (for non-conditionals)
• SC2251: This ! is not on a condition and skips errexit
• Stackoverflow: Why do I need parenthesis In bash set -e and negated return code
• bash manpage (look at trap [-lp] [[arg] sigspec ...]):

  The ERR trap is not executed [...] if the command's return value is being inverted via !

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.