1 SC2305

Vidar Holen edited this page 2021-08-22 20:14:10 -07:00

Table of Contents

• Quote regex argument to expr to avoid it expanding as a glob.
• Problematic code:
• Correct code:
• Rationale:
• Exceptions:
• Related resources:

Quote regex argument to expr to avoid it expanding as a glob.

Problematic code:

expr "$input" : [0-9]*

Correct code:

expr "$input" : "[0-9]*"

Rationale:

ShellCheck found an expr command using : to match a regex, but the regex is not quoted and therefore being treated as a glob.

This means that if the problematic code is ever executed in a directory containing a file matching [0-9]*, such as 2021-reports or 12 Angry Men [1957].mkv, it will be replaced be replaced and cause the command to error or incorrectly match.

The regex should be quoted to avoid this, like in the correct example.

Exceptions:

None

Related resources:

• Help by adding links to BashFAQ, StackOverflow, man pages, POSIX, etc!

ShellCheck

• Installation

  • CentOS6
  • More Installation Guides

• Usage

  • Directive
  • Ignore

• Integrating and extending

  • Misc. contributions
  • Azure Pipelines
  • Buildkite
  • CircleCI
  • DevGuide
  • Integration
  • JUnit
  • Phabricator
  • TravisCI
  • GitLab CI
  • Drone
  • GitHub Actions

• Severity

• Template

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.