github/shellcheck
1
0
Fork 0
mirror of https://github.com/koalaman/shellcheck.git synced 2025-03-12 12:35:25 -07:00
Code Issues Packages Projects Releases Wiki Activity

Simplify findFunction

Browse Source
This commit is contained in:
Joseph C. Sible 2020-02-09 21:08:32 -05:00
parent 172aa7c4fc
commit 21ad4196db
1 changed files with 4 additions and 6 deletions

10
src/ShellCheck/Analytics.hs

@ -2488,12 +2488,10 @@ checkUnpassedInFunctions params root =
map (\t@(T_Function _ _ _ name _) -> (name,t)) functions
functions = execWriter $ doAnalysis (tell . maybeToList . findFunction) root
findFunction t@(T_Function id _ _ name body) =
let flow = getVariableFlow params body
in
if any (isPositionalReference t) flow && not (any isPositionalAssignment flow)
then return t
else Nothing
findFunction t@(T_Function id _ _ name body)
| any (isPositionalReference t) flow && not (any isPositionalAssignment flow)
= return t
where flow = getVariableFlow params body
findFunction _ = Nothing
isPositionalAssignment x =