mirror of
https://github.com/mealie-recipes/mealie.git
synced 2024-10-18 05:00:24 -07:00
83b8ce659e
* Filtering special characters during automatic linking of ingredients to instructions Used a unicode group to have a set of all unicode punctuation marks * allowing for linking of ingredients to instruction at the beginning of a newline in the instruction * Extracted ingredient matching into a composable and added tests. Ignoring 2 letter words to avoid false matches. While testing the code 2 letter matches were a large source of false positives.
69 lines
3.1 KiB
TypeScript
69 lines
3.1 KiB
TypeScript
import { describe, expect, test } from "vitest";
|
|
import { useExtractIngredientReferences } from "./use-extract-ingredient-references";
|
|
|
|
const punctuationMarks = ["*", "?", "/", "!", "**", "&", "."];
|
|
|
|
|
|
describe("test use extract ingredient references", () => {
|
|
test("when text empty return empty", () => {
|
|
const result = useExtractIngredientReferences([{ note: "Onions", referenceId: "123" }], [], "", true)
|
|
expect(result).toStrictEqual(new Set());
|
|
});
|
|
|
|
test("when and ingredient matches exactly and has a reference id, return the referenceId", () => {
|
|
const result = useExtractIngredientReferences([{ note: "Onions", referenceId: "123" }], [], "A sentence containing Onion", true);
|
|
|
|
expect(result).toEqual(new Set(["123"]));
|
|
});
|
|
|
|
|
|
test.each(punctuationMarks)("when ingredient is suffixed by punctuation, return the referenceId", (suffix) => {
|
|
const result = useExtractIngredientReferences([{ note: "Onions", referenceId: "123" }], [], "A sentence containing Onion" + suffix, true);
|
|
|
|
expect(result).toEqual(new Set(["123"]));
|
|
});
|
|
|
|
test.each(punctuationMarks)("when ingredient is prefixed by punctuation, return the referenceId", (prefix) => {
|
|
const result = useExtractIngredientReferences([{ note: "Onions", referenceId: "123" }], [], "A sentence containing " + prefix + "Onion", true);
|
|
expect(result).toEqual(new Set(["123"]));
|
|
});
|
|
|
|
test("when ingredient is first on a multiline, return the referenceId", () => {
|
|
const multilineSting = "lksjdlk\nOnion"
|
|
const result = useExtractIngredientReferences([{ note: "Onions", referenceId: "123" }], [], multilineSting, true);
|
|
expect(result).toEqual(new Set(["123"]));
|
|
});
|
|
|
|
test("when the ingredient matches partially exactly and has a reference id, return the referenceId", () => {
|
|
const result = useExtractIngredientReferences([{ note: "Onions", referenceId: "123" }], [], "A sentence containing Onions", true);
|
|
expect(result).toEqual(new Set(["123"]));
|
|
});
|
|
|
|
|
|
test("when the ingredient matches with different casing and has a reference id, return the referenceId", () => {
|
|
const result = useExtractIngredientReferences([{ note: "Onions", referenceId: "123" }], [], "A sentence containing oNions", true);
|
|
expect(result).toEqual(new Set(["123"]));
|
|
});
|
|
|
|
test("when no ingredients, return empty", () => {
|
|
const result = useExtractIngredientReferences([], [], "A sentence containing oNions", true);
|
|
expect(result).toEqual(new Set());
|
|
});
|
|
|
|
test("when and ingredient matches but in the existing referenceIds, do not return the referenceId", () => {
|
|
const result = useExtractIngredientReferences([{ note: "Onion", referenceId: "123" }], ["123"], "A sentence containing Onion", true);
|
|
|
|
expect(result).toEqual(new Set());
|
|
});
|
|
|
|
test("when an word is 2 letter of shorter, it is ignored", () => {
|
|
const result = useExtractIngredientReferences([{ note: "Onion", referenceId: "123" }], [], "A sentence containing On", true);
|
|
|
|
expect(result).toEqual(new Set());
|
|
|
|
})
|
|
|
|
|
|
|
|
});
|